Skip to content

feat(core): implement missing signing host fn - #288

Merged
TarikGul merged 25 commits into
mainfrom
feat/signing-host-ring-vrf
Jul 28, 2026
Merged

feat(core): implement missing signing host fn#288
TarikGul merged 25 commits into
mainfrom
feat/signing-host-ring-vrf

Conversation

@pgherveou

@pgherveou pgherveou commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • implement direct signing-host RFC-0004 alias and Bandersnatch ring-VRF proof generation
  • mirror Nova full/lite person-key derivation and membership selection
  • resolve Members pallet storage at one pinned finalized block, including ring pages, exponent, index, and revision
  • use the Parity verifiable revision shared by the mobile implementation

Reference implementations:

Validation

  • cargo +nightly fmt --check
  • RUSTFLAGS="-D warnings" cargo build --workspace --all-targets --all-features
  • cargo +nightly clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --workspace --all-features
  • RUSTFLAGS="-D warnings" cargo check -p truapi-server --target wasm32-unknown-unknown
  • cargo deny check licenses

@pgherveou
pgherveou requested a review from a team July 17, 2026 17:09
pgherveou added a commit that referenced this pull request Jul 21, 2026
@pgherveou
feat(host): integrate signing-host ring VRF
d7e76f6 
Preserve headless SSO resource allocation while aligning Ring-VRF wire variants and confirmation policy with the iOS host.

Refs #264, #288
@pgherveou pgherveou changed the title feat(core): implement ring-vrf signing feat(core): implement missing signing host fn Jul 23, 2026
@pgherveou pgherveou mentioned this pull request Jul 23, 2026
Merged
pgherveou
pgherveou commented Jul 23, 2026
View reviewed changes
Comment thread rust/crates/truapi-server/src/host_logic/sso/messages.rs
@TarikGul

TarikGul commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary of what I added in the above:

  • Statement-store proof signing now uses its own StatementStoreProductSignReview the confirmation matches the unwrapped statement payload that actually gets signed, instead of borrowing the raw-message (<Bytes>-wrapped) review.
  • Resource-allocation confirmation now names the beneficiary product via ResourceAllocationReview.calling_product_id, so approving a delegated allowance key shows which product it's going to.
  • SSO responder replay-dedup is now bounded (fixed capacity, evicts oldest) so a paired peer holding the session open can't grow it without bound on the signing device.

NOTE: the two review types change UserConfirmationReview, so host confirmation UIs (iOS/dotli) need to render the new/updated variants, and the codegen golden is refreshed to match. One of the commits also re-blesses a pre-existing stale golden (the AccountAccess variant) that was already red on a clean checkout unrelated to these fixes.

pgherveou and others added 7 commits July 24, 2026 07:42
@pgherveou
fix(server): align runtime SCALE codecs
103431c 
Use codec-derived runtime payloads and metadata-aware storage projections so field ordering and variant encoding stay aligned with chain types. Derive SSO message labels once and keep normal transcript events at debug.
@pgherveou
update
0e7e96e
pg pg
Merge branch 'main' into feat/signing-host-ring-vrf
eaaea86
pg pg
Address signing host review feedback
e36daf9
pg pg
Fix wasm runtime config error mapping
3739244
pg pg
Merge remote-tracking branch 'origin/main' into feat/signing-host-rin…
8ff9af0 
…g-vrf

# Conflicts:
#	rust/crates/truapi-server/src/runtime/bulletin_rpc.rs
pg pg
Fix platform clone-on-copy clippy warning
428cdd6
TarikGul
TarikGul approved these changes Jul 28, 2026
View reviewed changes

@TarikGul TarikGul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, ran through a review and everything that was previously brought up is addressed plus some.

I think we can get this in and follow up with anything if we need.

@pgherveou
pgherveou added this pull request to the merge queue Jul 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 28, 2026
@TarikGul
TarikGul added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit 9211243 Jul 28, 2026
13 checks passed
@TarikGul
TarikGul deleted the feat/signing-host-ring-vrf branch July 28, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TarikGul TarikGul TarikGul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pgherveou @TarikGul